ISAAKiel / oxcAAR

R Package - Interaction with Oxcal
GNU General Public License v2.0
21 stars 4 forks source link

Graceful fail for downloading oxcal requested #43

Open MartinHinz opened 3 years ago

MartinHinz commented 3 years ago

Prof. Brian Ripley wrote 28th of June 2021:

Dear maintainer,

Please see the problems shown on https://cran.r-project.org/web/checks/check_results_oxcAAR.html.

Please correct before 2021-07-12 to safely retain your package on CRAN.

It seems we need to remind you of the CRAN policy:

'Packages which use Internet resources should fail gracefully with an informative message if the resource is not available or has changed (and not give a check warning nor error).'

This needs correction whether or not the resource recovers.

The CRAN Team

MartinHinz commented 3 years ago

implemented desired behavior in Branch quickfix_download_and_cran_checks with 1ee51c2c97900928a691f21de1c10631a17a2adc and 3cd31e0123ef8a1ac6f2be7bab36b1d347717bda. Next steps: CRAN re-release: suggested name: Karpo.

MartinHinz commented 3 years ago

Remerge into master is requested after review.

MartinHinz commented 3 years ago

After that: Check for release/resubmit:

MartinHinz commented 3 years ago

PR #44 Remerged into master, now prerelease-check.

MartinHinz commented 3 years ago

All resubmit checks passed, PR prerelease branch into master

MartinHinz commented 3 years ago

merged #45 into master. Initiating devtools::release().