search

ISBX / apprtc-ios

A native iOS video chat app based on WebRTC
BSD 3-Clause "New" or "Revised" License
1.35k stars 413 forks source link

latest webrtc #98

Open mostafa-v opened 7 years ago

mostafa-v commented 7 years ago

Hi Could you please update pods to newest webrtc pod (https://cocoapods.org/pods/WebRTC) instead of libjingle? Webrtc pod updated much more recently than libjingle. There is another repo (https://github.com/inspiraluna/AppRTC-iOS) that stopped using libjingle and now uses that pod (But I don't use it because I use original apprtc server not Kurento apprtc server)

manish-1988 commented 6 years ago

Same concern I have, I have integrated Twilio on my application with this library but after Twilio integration, ISBX-AppRTC is crashing on video call with this particular error

"-[RTCI420Frame nativeHandle]: unrecognized selector sent to instance 0x170017c30"

If possible please update to webRTC 57 which is latest as old libjingle is causing crashing issue for my use case scenario.

karlvr commented 6 years ago

I have a fork that uses the latest WebRTC pod, which is apparently v60. It works with appr.tc, so it seems to be a good start, if not perfect. Particularly, the camera hangs when orientation changes. I think that might be to do with which queue the camera is setup on, so I'm going to work on that.

For anyone interested, here is my fork: https://github.com/karlvr/apprtc-ios/tree/webrtc-pod

Once I have it going 100% I'll make a PR, in case the owner is interested in merging this.