ISET / iset3d-v3

LEGACY: Replaced by iset3d (v4) -- Read a PBRT file. Edit the parameters. Render an ISET scene or optical image.
MIT License
36 stars 8 forks source link

t_Example_SceneAssembly broken, or we failed to install something we need #11

Open DavidBrainard opened 5 years ago

DavidBrainard commented 5 years ago

Here is the error message. Does this work for you? Is there a dependency we need to install that isn't listed on the installation wike page?


Undefined function or variable 'skyname'.

Error in piSkymapAdd (line 44) skylights = sprintf('LightSource "infinite" "string mapname" "%s"',skyname);

Error in t_piExample_SceneAssembly (line 43) thisR = piSkymapAdd(thisR,'day');

Zhenyi-Liu commented 5 years ago

Hi David, I am sorry that "t_piExample_sceneAssembly" is a very early script when I started working on this, and it hasn't been updated since then, some functions and descriptions are not true now. so I think it will be helpful for us to show you the right script(or write a new one) if you let us know what you would like to achieve with this toolbox, and of course, we will keep cleaning up and commenting the scripts.

DavidBrainard commented 5 years ago

Thanks! At this very early juncture, our goal is to explore the toolbox and look at examples of how things are done. So we just tried running two of the tutorials. In ISETBio, we have found it helpful to move broken and obsolete tutorials into subdirectories with a name such as "xUnderDevelopment" as way to communicate to users that they may not be working or correct. We will continue to explore, and to post issues when we discover things that don't work or that we can't understand. Once we've gotten a little further, we may be able to articulate some specific rendering goals.

DavidBrainard commented 5 years ago

This got further, but now dies because I don't know what to enter when it asks me for an API key. Error message below.

t_piExample_SceneAssembly Warning: Cannot find "filter" in PBRT file.

In piRead (line 195) In t_piExample_SceneAssembly (line 21) Warning: "Renderer" does not exist in the new PBRTv3 format. We leave the field blank . In piRead (line 227) In t_piExample_SceneAssembly (line 21) Read 1 materials on 2 lines Warning: Directory already exists. In piTextureFileFormat (line 68) In piRead (line 314) In t_piExample_SceneAssembly (line 21) Starting... Object:Plane has 1 children object(s) All done. Please enter the API key (domain:key format): User canceled Undefined variable "flywheel" or class "flywheel.Flywheel".

Error in scitran (line 92) obj.fw = flywheel.Flywheel(obj.showToken);

Error in piSkymapAdd (line 66) st = scitran('stanfordlabs');

Error in t_piExample_SceneAssembly (line 43) thisR = piSkymapAdd(thisR,'noon');

Zhenyi-Liu commented 5 years ago

Hi @DavidBrainard , you need to create a flywheel account first, and the API key is the secret key you need to provide to connect to Flywheel, here is the scitran wiki page you can look into.

DavidBrainard commented 5 years ago

Now this crashes with a file not found error on line 18. It's looking for data/V3/checkerboard, which does not seem to exist. There is a data/checkerboard but when I switch the command to look for that, it also crashes out:

Warning: Cannot find "integrator" in PBRT file. Did you forget to turn on the v3 flag?

In piRead (line 210) In t_piExample_SceneAssembly (line 22) A dot name structure assignment is illegal when the structure is empty. Use a subscript on the structure.

Error in t_piExample_SceneAssembly (line 33) thisR.integrator.maxdepth.value = 10;

wandell commented 5 years ago

Probably my fault from yesterday. Zhenyi seemed to think that checkerboard was not to be included in the repository. I will pull it back in.

Can you run the scripts in tutorial/introduction. That was our start on creating a simple and clear opening.

Will add you as admin very shortly.


Sent from my iPad


From: David Brainard notifications@github.com Sent: Monday, November 12, 2018 6:51:07 AM To: ISET/iset3d Cc: Subscribed Subject: Re: [ISET/iset3d] t_Example_SceneAssembly broken, or we failed to install something we need (#11)

Now this crashes with a file not found error on line 18. It's looking for data/V3/checkerboard, which does not seem to exist. There is a data/checkerboard but when I switch the command to look for that, it also crashes out:

Warning: Cannot find "integrator" in PBRT file. Did you forget to turn on the v3 flag?

In piRead (line 210) In t_piExample_SceneAssembly (line 22) A dot name structure assignment is illegal when the structure is empty. Use a subscript on the structure.

Error in t_piExample_SceneAssembly (line 33) thisR.integrator.maxdepth.value = 10;

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/ISET/iset3d/issues/11#issuecomment-437909107, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABwIWWFrk2p-LV50bQbeEAQKQcdOnOgyks5uuYragaJpZM4YLrsJ.

wandell commented 5 years ago

We also got rid of the warnings, and we made V3 the default.


Sent from my iPad


From: David Brainard notifications@github.com Sent: Monday, November 12, 2018 6:51:07 AM To: ISET/iset3d Cc: Subscribed Subject: Re: [ISET/iset3d] t_Example_SceneAssembly broken, or we failed to install something we need (#11)

Now this crashes with a file not found error on line 18. It's looking for data/V3/checkerboard, which does not seem to exist. There is a data/checkerboard but when I switch the command to look for that, it also crashes out:

Warning: Cannot find "integrator" in PBRT file. Did you forget to turn on the v3 flag?

In piRead (line 210) In t_piExample_SceneAssembly (line 22) A dot name structure assignment is illegal when the structure is empty. Use a subscript on the structure.

Error in t_piExample_SceneAssembly (line 33) thisR.integrator.maxdepth.value = 10;

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/ISET/iset3d/issues/11#issuecomment-437909107, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABwIWWFrk2p-LV50bQbeEAQKQcdOnOgyks5uuYragaJpZM4YLrsJ.

wandell commented 5 years ago

I added checkerboard back into the master branch. Also, made t_Introduction01.m t_piIntroduction01.m.