search

ISET / iset3d-v3

LEGACY: Replaced by iset3d (v4) -- Read a PBRT file. Edit the parameters. Render an ISET scene or optical image.
MIT License
36 stars 8 forks source link

Depth map should probably be written out in piRender instead of piWrite #2

Closed tlian7 closed 6 years ago

tlian7 commented 6 years ago

I'm thinking that the depth map should be written out in piRender instead of piWrite. I think this might be a better idea because of the following scenario:

Say we have a single PBRT file (xxx.pbrt) we got online that we want to render. If we run piRender we will get an error since there is no corresponding (xxx_depth.pbrt) that goes with it. So instead, the user has to figure out what the error means, and then specifically run piRender('xxx.pbrt','renderType','radiance') so that piRender isn't looking for a depth map.

It seems to me that re-reading the recipe in piRender and then writing out a xxx_depth.pbrt file seems to make more sense.

tlian7 commented 6 years ago

Done. Turned out to be a pretty easy change.