search

ISET / iset3d-v3

LEGACY: Replaced by iset3d (v4) -- Read a PBRT file. Edit the parameters. Render an ISET scene or optical image.
MIT License
36 stars 8 forks source link

Checkerboard cleanup #27

Closed hblasins closed 5 years ago

tlian7 commented 5 years ago

Looks great and runs perfectly on my machine. This will be very useful for the repository, especially the all-in-one function to make planar checkerboards of arbitrary sizes and grids. I made a few very, very minor syntax changes (are you using Windows @hblasins?) to match the rest of the repository.

tlian7 commented 5 years ago

Apologies if I went ahead and merged the branch without first submitting a review. I've never had a requested review before, I guess the correct way I should have gone about doing things was to submit a review before merging right?

I thought hitting the merge button would have led me to some review submission...anyhow the branch did look ready to merge.