search

ISET / iset3d-v3

LEGACY: Replaced by iset3d (v4) -- Read a PBRT file. Edit the parameters. Render an ISET scene or optical image.
MIT License
36 stars 8 forks source link

t_assetsMergeScene #35

Open DavidBrainard opened 3 years ago

DavidBrainard commented 3 years ago

This runs but I found it difficult to follow in several places. I added comments IN ALL CAPS at places where additional commenting and explanation would be helpful.

digital-pro commented 3 years ago

David – I also get all black when the second scene is rendered, but in case it helps, if I switch the rendering mode from HDR to RGB, I do get an image. Haven’t investigated any further.

From: David Brainard notifications@github.com Sent: Saturday, January 09, 2021 2:23 PM To: ISET/iset3d iset3d@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [ISET/iset3d] t_assetsMergeScene (#35)

This runs but I found it difficult to follow in several places. I added comments IN ALL CAPS at places where additional commenting and explanation would be helpful.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ISET/iset3d/issues/35 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJ4N3DDI4IVH24JS5BVRLTSZDJM7ANCNFSM4V35GR7A . https://github.com/notifications/beacon/ABJ4N3EYH63WGS4VCHUX76TSZDJM7A5CNFSM4V35GR7KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4LVG76WQ.gif

DavidBrainard commented 3 years ago

That's good. Seeing what the coordinate scene looks like helps. I updated the script so that you can see all the scenes by default in the scene window. Still some mysteries as indicated by comments in all caps, but may be able to get further with an understanding of what the coordinate scene is.

Best,

David

From: David Cardinal notifications@github.com Reply-To: ISET/iset3d reply@reply.github.com Date: Saturday, January 9, 2021 at 6:36 PM To: ISET/iset3d iset3d@noreply.github.com Cc: "Brainard, David H" brainard@psych.upenn.edu, Author author@noreply.github.com Subject: Re: [ISET/iset3d] t_assetsMergeScene (#35)

David – I also get all black when the second scene is rendered, but in case it helps, if I switch the rendering mode from HDR to RGB, I do get an image. Haven’t investigated any further.

From: David Brainard notifications@github.com Sent: Saturday, January 09, 2021 2:23 PM To: ISET/iset3d iset3d@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [ISET/iset3d] t_assetsMergeScene (#35)

This runs but I found it difficult to follow in several places. I added comments IN ALL CAPS at places where additional commenting and explanation would be helpful.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ISET/iset3d/issues/35 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJ4N3DDI4IVH24JS5BVRLTSZDJM7ANCNFSM4V35GR7A . https://github.com/notifications/beacon/ABJ4N3EYH63WGS4VCHUX76TSZDJM7A5CNFSM4V35GR7KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4LVG76WQ.gif

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/ISET/iset3d/issues/35#issuecomment-757384184, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAI24ZJVZRKHCQZVS5Y5O23SZDR7HANCNFSM4V35GR7A.