search

ISET / iset3d-v3

LEGACY: Replaced by iset3d (v4) -- Read a PBRT file. Edit the parameters. Render an ISET scene or optical image.
MIT License
36 stars 8 forks source link

Underwater update #37

Closed hblasins closed 3 years ago

hblasins commented 3 years ago

Updated the underwater code to work with latest changes.

hblasins commented 3 years ago

Changed base branch, added reviewers.

wandell commented 3 years ago

Hi Henryk, This looked good and clear, and it had no conflicts.

When you are ready, send me a script that I might run to demonstrate the basic functionality of the new 'mediumInterface' features. It may be in there already, and I won't get to it soon. Still, it would be very nice to try running this feature and understand it better.

Onward, Brian

hblasins commented 3 years ago

Hi Brian,

thanks for merging. I’ve added another small feature that was missing from the dev branch.

I do have a plan to create a few sample scripts and tutorials, but before this happens there is a bit of work ahead of me. I need to clean-up the PBRT code and figure our a few remaining inconsistencies. For example the simulated attenuation due to the medium matches the expectation quite well, when the medium is small, but differences become larger, as the volume of water grows. I will feel more comfortably when those problems get resolved.

Best, Henryk

Wiadomość napisana przez Brian Wandell notifications@github.com<mailto:notifications@github.com> w dniu 01.02.2021, o godz. 02:01:

Hi Henryk, This looked good and clear, and it had no conflicts.

When you are ready, send me a script that I might run to demonstrate the basic functionality of the new 'mediumInterface' features. It may be in there already, and I won't get to it soon. Still, it would be very nice to try running this feature and understand it better.

Onward, Brian

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/ISET/iset3d/pull/37#issuecomment-770494165, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABANCKMXCFZ2GGGBT6MJLQLS4X4N5ANCNFSM4W3PBEGQ.