search

ISET / iset3d-v3

LEGACY: Replaced by iset3d (v4) -- Read a PBRT file. Edit the parameters. Render an ISET scene or optical image.
MIT License
36 stars 8 forks source link

Modification of the Retinal Shape #45

Open benjaminralex opened 3 years ago

benjaminralex commented 3 years ago

Hello,

Immensely enjoying this tool. It is extremely powerful and versatile. Thank you for making it available to the research community.

Question: is it possible to modify the 3D retinal surface? Introduce aberrations/structural changes?

If so, which function would enable a user to do that?

Thanks!

benjaminralex commented 3 years ago

Any leads/suggestions on this?

wandell commented 3 years ago

I will send you some slides about the (small) modifications we can make now. These concern only the curvature. This involves setting the radius and semidiameter.

Trisha and I spoke a bit about your idea: How one might do more complex modifications – which does seem interesting to me. I am not sure. Our conversations were significantly delayed, as was my response to you, because this is the week of VSS. It ends today. Sorry for the slow response.

Brian

From: Alex Benjamin @.> Date: Wednesday, May 26, 2021 at 9:48 AM To: ISET/iset3d @.> Cc: Subscribed @.***> Subject: Re: [ISET/iset3d] Modification of the Retinal Shape (#45)

Any leads/suggestions on this?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/ISET/iset3d/issues/45#issuecomment-848939891, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAOAQWNFJCAV36UVYF7JEM3TPUQ4NANCNFSM45FNC5SQ.

benjaminralex commented 3 years ago

Thank you! Much appreciated.

wandell commented 3 years ago

The basic geometry that we currently model is illustrated in this figure, from this talkhttps://scarlet.stanford.edu/~brian/talks/2020-ISET3d-OSA-Webinar.pdf. (Here is the video)https://osa.zoom.us/rec/play/7MZ-dL2q_Dw3HNfA5ASDAf56W43pK6isgHUd-6YKykjjUSUEZ1GkZbsSNLCijLV_SPFxtXDbxkCePFVR.

@.***D752D2.42E03A40]

The semi-diameter parameter ends up controlling the field of view. The radius controls the curvature, of course. The focal distance and radius need to be coordinated to make the image. There are some scripts that set these parameters (t_eyeFOV.m), but there should be more. I don’t think we ever adjust the radius.

Your idea that we should be able to specify a shape for the retinal surface, allowing bumps and aspherical shapes, seems right to me. I don’t know how to do that. I am not deeply knowledgeable about how PBRT specifies the 3D location of the film pixels.

I will talk it over with Trisha, Zheng, Zhenyi and Thomas who are all more knowledgeable about the PBRT code. Perhaps we could modify the code to permit input arguments that specific the surface and sampling strategy.

Brian

From: Alex Benjamin @.> Date: Wednesday, May 26, 2021 at 1:47 PM To: ISET/iset3d @.> Cc: Brian A Wandell @.>, Comment @.> Subject: Re: [ISET/iset3d] Modification of the Retinal Shape (#45)

Thank you! Much appreciated.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/ISET/iset3d/issues/45#issuecomment-849106416, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAOAQWIMFS4OLYS5DVPPLT3TPVM6HANCNFSM45FNC5SQ.