search

ISET / iset3d-v3

LEGACY: Replaced by iset3d (v4) -- Read a PBRT file. Edit the parameters. Render an ISET scene or optical image.
MIT License
36 stars 8 forks source link

Unrecognized function or variable 'lightsWritten' #46

Open AmyMNi opened 3 years ago

AmyMNi commented 3 years ago

Hi all,

When running t_piIntro_light.m on the dev branch, I get the following error:

Unrecognized function or variable 'lightsWritten'.

Error in piWrite>piIncludeLines (line 664) if piContains(currLine, 'WorldEnd') && lightsWritten == false

Error in piWrite (line 193) piIncludeLines(thisR,fileID, creatematerials,overwritegeometry);

Error in t_piIntro_light (line 92) piWrite(thisR);

I first got this error when trying to render my natural scenes, which I how I came across it. Thanks in advance! Amy

wandell commented 3 years ago

I think master is running at this point. At least v_iset3d runs fo4 me.

Also, can you give the sceneauto branch a try, please. If we can get you running on Blender and everything else on that branch, life will be much simpler.

I see the error on dev. I will try to figure it out tomorrow.

Sent from my iPad

From: Amy Ni @.> Sent: Wednesday, June 2, 2021 10:26:00 PM To: ISET/iset3d @.> Cc: Subscribed @.***> Subject: [ISET/iset3d] Unrecognized function or variable 'lightsWritten' (#46)

Hi all,

When running t_piIntro_light.m on the dev branch, I get the following error:

Unrecognized function or variable 'lightsWritten'.

Error in piWrite>piIncludeLines (line 664) if piContains(currLine, 'WorldEnd') && lightsWritten == false

Error in piWrite (line 193) piIncludeLines(thisR,fileID, creatematerials,overwritegeometry);

Error in t_piIntro_light (line 92) piWrite(thisR);

I first got this error when trying to render my natural scenes, which I how I came across it. Thanks in advance! Amy

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/ISET/iset3d/issues/46, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAOAQWOBCY2CLI2SWEJVAC3TQ4G6RANCNFSM46AALGDQ.

AmyMNi commented 3 years ago

Thank you, testing sceneauto branch now with Blender export. I'm not able to add a light (which is to say, no error when using piLightCreate, but the rendered scene is an all black image). Will try to track this down.

AmyMNi commented 3 years ago

Update: I'm able to add an infinite light and render an all white image, so the problem is not with adding lights.

wandell commented 3 years ago

@ZhengLyuFelix is the one who solves my problems when we get to this stage. But I am glad to Zoom with you to try to track down the issue. Does the master branch work, by the way?

AmyMNi commented 3 years ago

Yes, master branch still works. I’m happy to work on the sceneauto branch to get it working with Blender exports, though it won’t be today.

Best, Amy

On Thu, Jun 3, 2021 at 6:52 PM Brian Wandell @.***> wrote:

@ZhengLyuFelix https://github.com/ZhengLyuFelix is the one who solves my problems when we get to this stage. But I am glad to Zoom with you to try to track down the issue. Does the master branch work, by the way?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ISET/iset3d/issues/46#issuecomment-854236647, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARUBITCL7XJCQOIJIQ3T6PLTRABRNANCNFSM46AALGDQ .

wandell commented 3 years ago

We tagged the master version that runs with Blender and saved it, so we will always have that.

I will try to work with Zheng on the Blender script to see if we can get it working without your intervention on sceneauto. He is headed off to Apple soon, but maybe we can get it done before that!

ZhengLyuFelix commented 3 years ago

Thanks for the notification, yes we the logic of that section in dev branch is not robust. We think (hope) that the problem has been fixed in sceneauto. WIll work with Brian on it.

AmyMNi commented 3 years ago

Thank you! Congrats to Zheng! I’ll also stay in touch if I find anything useful.

Best, Amy

On Thu, Jun 3, 2021 at 6:59 PM Brian Wandell @.***> wrote:

We tagged the master version that runs with Blender and saved it, so we will always have that.

I will try to work with Zheng on the Blender script to see if we can get it working without your intervention on sceneauto. He is headed off to Apple soon, but maybe we can get it done before that!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ISET/iset3d/issues/46#issuecomment-854239295, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARUBITDCEGLOT4D3ECBQZYTTRACL3ANCNFSM46AALGDQ .