search

ISET / isetL3

Linear, Local, Learned
3 stars 6 forks source link

Wavelength sampling in design sensor and ideal filters #1

Closed wandell closed 8 years ago

wandell commented 9 years ago

The design sensor and the ideal filter transmissivities may not have the same wavelength samples. This is bad, I think. We should try to make sure the L3 wavelengths of the sensor and ideal filters always are on the same wavelength sample values.

qytian commented 9 years ago

Sure I agree. I have not done these checkings very carefully. Definitely we need improvement.

Best QT

Sent from my iPhone

On Feb 7, 2015, at 9:38 AM, Brian Wandell notifications@github.com wrote:

The design sensor and the ideal filter transmissivities may not have the same wavelength samples. This is bad, I think. We should try to make sure the L3 wavelengths of the sensor and ideal filters always are on the same wavelength sample values.

— Reply to this email directly or view it on GitHub.

hblasins commented 9 years ago

Are you refering to the general case or the specific five-band sensor? I looked at the fbCreate code and it seems that we are re-sampling these curves to match the desired wavelength sampling.

wandell commented 9 years ago

Yes, the general case. I might have handled it. Will keep checking.

QT and FG are finishing their slides here today. Busy.

B

Sent from a mobile device

On Feb 7, 2015, at 5:51 PM, hblasins notifications@github.com wrote:

Are you refering to the general case or the specific five-band sensor? I looked at the fbCreate code and it seems that we are re-sampling these curves to match the desired wavelength sampling.

— Reply to this email directly or view it on GitHub.

wandell commented 8 years ago

This issue seems to be resolved by now. Following HJ's lead today, and closing.