Implement spinwheel & RNG feedback

ISH-Gruppe / screenario

Screenario - The screen for every scenario

https://screenar.io

GNU General Public License v3.0

2 stars 2 forks source link

Implement spinwheel & RNG feedback #157

Closed LBBO closed 8 months ago

LBBO commented 9 months ago

Rename "Namen auslosen" to "Begriffe auslosen"
Add all of the lists in the spinwheel to the state, which means persistence between opened instances & exports
Add option to draw fresh options
Play sound effect while wheel is still spinning (⚠️ @liam-k: you still need to find a proper sound for this!)

Reviewer's task:

[ ] I didn't see no code smells
[ ] The live preview works as expected -> no regressions found

render[bot] commented 9 months ago

Your Render PR Server URL is https://screenario-school-pr-157.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-cmlau0n109ks73co0kfg.

liam-k commented 9 months ago

Thanks! Seems to work well – one thing though: The "don’t repeat options" thing could be kind of confusing I think, because it just starts over after all options have been selected once. Could we have some kind of indicator?

Maybe we can just rename the "Drehen" button to "Drehen (neuer Durchlauf)" or similar after all options have been called once (& at the start of course, if "don’t repeat" is enabled).

Also, we should rename "Zahlen 1-8" to "Zahlen" now.

LBBO commented 9 months ago

It's no different with "Begriffe auslosen" tho

liam-k commented 9 months ago

It's no different with "Begriffe auslosen" tho

Yeah, but there we have visual feedback so you intuitively know it’s over. Maybe that could work for the spinwheel too, just remove names we already had? (just make sure they stay in the textbox tho)

https://github.com/ISH-Gruppe/screenario/assets/34057943/1717dcac-5826-4eaa-a53b-85f93702335c

LBBO commented 9 months ago

done