ISH-Gruppe / screenario

Screenario - The screen for every scenario
https://screenar.io
GNU General Public License v3.0
2 stars 2 forks source link

Add input checking to QR Code Generator #18

Closed liam-k closed 2 years ago

liam-k commented 2 years ago

The QR Code Generator currently generates a QR code for whatever you put into the text field. Assuming that users would want to create QR codes for a link 99% of the time, we should check the text input for a correct URL before we generate and if the check fails, display some info to the user. Otherwise it could result in invalid QR codes if users mistype.

(low priority – do we have a tag for that in this repo?)

s-gbz commented 2 years ago

If you don't mind, I'd like to deprioritize this as an item in the backlog or personally just put it off, because I have a lot of questions concerning it's usability.

So yeah, if you want to, let's label it as nice-to-have and talk to the client about it. It might be part of a nice followup service.

06.08.2022 15:14:47 liam-k @.***>:

The QR Code Generator currently generates a QR code for whatever you put into the text field. Assuming that users would want to create QR codes for a link 99% of the time, we should check the text input for a correct URL before we generate and if the check fails, display some info to the user. Otherwise it could result in invalid QR codes if users mistype.

— Reply to this email directly, view it on GitHub[https://github.com/s-gbz/screenario-react/issues/18], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AFSW4GT6UIEML6EX2WJEVPDVXZQMLANCNFSM55YSITBQ]. You are receiving this because you are subscribed to this thread. [data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAEIAAABCCAYAAADjVADoAAAAAXNSR0IArs4c6QAAAARzQklUCAgICHwIZIgAAAAnSURBVHic7cEBDQAAAMKg909tDwcUAAAAAAAAAAAAAAAAAAAAAPBjRFIAASHKmKkAAAAASUVORK5CYII=###24x24:true###][Verfolgungsbild][https://github.com/notifications/beacon/AFSW4GRGQAQ6DOWL6TWE2WDVXZQMLA5CNFSM55YSITB2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4T2RUFPA.gif]

s-gbz commented 2 years ago

And yeah feel free to create a new label for that. I'd suggest avoiding "priority-high/mid/low" since everything we do should be high priority atm. We might create "backlog" or "nice-to-have"?

liam-k commented 2 years ago

Yeah good points, let’s distinguish between nice-to-have & must-have then, that’s pretty much what I meant with low priority anyway (bc in what world do low prio tasks ever get done anyway?)

liam-k commented 2 years ago

Closing this – it’s fine, tbh.