ISH-Gruppe / screenario

Screenario - The screen for every scenario
https://screenar.io
GNU General Public License v3.0
2 stars 2 forks source link

Improve responsiveness of the Stuhlkreis window #21

Closed liam-k closed 2 years ago

liam-k commented 2 years ago

The "digitaler Stuhlkreis" doesn’t react to vertical resizing via react-grid-layout. No matter what you set it to, it always stays at 100% height.

image

I looked at the CSS and this css ID seems to be the culprit:

image

Should be an easy fix but I’d rather not dig through that codebase.

s-gbz commented 2 years ago

Yeah, believe it or not, I deliberately left the component at 100% min-height when I imported it, because it appeared a little weird outherwise. Thing is, it's not really built for being shrinked in height, but rather in width. However, I'll take a look closer look later this week and we'll argue that it's feature rather than a bug if in doubt. (But I got you, that's not meant to dismiss the issue off)

Notes to myself:

app-outer-wrapper

min-height inline below app-component

liam-k commented 2 years ago

got it, but for what it’s worth I think this is pretty important, at least shrinking it down to like 80% height or something – even if it means modifying the app. Otherwise it’s either very hard to use when too narrow, or it’s obstructing the whole canvas.

Cheap hack could be to just use a css-transform scale and scale it down to 90% or something.

liam-k commented 2 years ago

Sorry, but in combination with the toolbar & BaseWindow Topbar, this is not just nice-to-have anymore. It just doesn’t fit the canvas at all anymore, it makes unnecessary scrollbars appear, and it’s just a clunky experience in general... we do need some kind of fix.

https://user-images.githubusercontent.com/34057943/183790755-29d7418f-bc4a-48b8-a93c-addf8e529e18.mov

s-gbz commented 2 years ago

Got it!

s-gbz commented 2 years ago