search

ISH-Gruppe / screenario

Screenario - The screen for every scenario
https://screenar.io
GNU General Public License v3.0
2 stars 2 forks source link

Redesign the GroupGenerator in the RandomGeneratorModule #3

Closed s-gbz closed 2 years ago

s-gbz commented 2 years ago

Apparently, the view for "number of groups to create" is not big enough for the client. image

I don't know, feel free to go at it image

s-gbz commented 2 years ago

Hey @liam-k have you had a chance to give it another thought? (Sorry if yes and it's already been updated in FIGMA)

liam-k commented 2 years ago

Did a quick little mockup (of course there should be tabs on top, it’s just the groupgenerator). Please read my comments on FIGMA as well

image

Also, if you could design it in a way where all 3 random generators have a similar width and height (or are responsive and don’t change width & height upon change, like it’s the case in screenario-angular right now), that would be great. I don’t know how well react-grid handles size changes coming from components internally

s-gbz commented 2 years ago

Also, if you could design it in a way where all 3 random generators have a similar width and height (or are responsive and don’t change width & height upon change, like it’s the case in screenario-angular right now), that would be great. I don’t know how well react-grid handles size changes coming from components internally

Surely! It was rather unfortunate, because Angular Material messed with the internal dimensions :/

Thanks for providing this idea! I like the big numbers! There's two adjustmens I will have to take though

  1. The name list has to be a textarea. This is very intentional in the original application since teachers/ users typically copy & paste their name lists from other documents
  2. I think it's great that we get a sneak peak of how the groups are distributed, however I'm afraid that it needs to be a view on its own since it's again too small otherwise

So, no need to reinvent the Tesla completely - this is a great addition to the previous design and together it shall be glorious. Thank you! :heart:

liam-k commented 2 years ago

👍 Though I think the group view of design B is large enough. If the lists are longer they’ll just expand to the bottom. And if they’re too small (which I don’t really see), you could do two columns instead of 3 or move them to the bottom altogether. I just think it’s more intuitive and much faster if you don’t have to switch between the two views, I found that to be a bit confusing in the original version. And react makes it easy to just generate the groups on the fly anyway. That’s just my 2 cents tho!