search

ISH-Gruppe / screenario

Screenario - The screen for every scenario
https://screenar.io
GNU General Public License v3.0
2 stars 2 forks source link

Give stuhlkreis a BaseWindow #36

Closed liam-k closed 2 years ago

liam-k commented 2 years ago

I tried doing it in my current branch but I honestly don’t understand how this component works 😅. Should be a quick thing for you I think.

Also, could we rename digitaler-stuhlkreis to DigitalerStuhlkreis to keep component names consistent?

liam-k commented 2 years ago

oh, I just saw your PR. We could just not wrap it into a BaseWindow, but I think we do need a button to minimize it at least. If we can manage to give it a BaseWindow it would be great though. Maybe we could just add the top bar to it (should be easily extractable from BaseWindow as a separate component).

s-gbz commented 2 years ago

I'll see what I can do. Probably a custom adaption of BaseWindow 👍

liam-k commented 2 years ago

Couldn’t we just remove all padding from BaseWindow in general, except for the top bar? And then re-add for the components where we need it.