search

ISH-Gruppe / screenario

Screenario - The screen for every scenario
https://screenar.io
GNU General Public License v3.0
2 stars 2 forks source link

Fix/responsify soundboard #80

Closed s-gbz closed 2 years ago

s-gbz commented 2 years ago

Closes #73

Hey there, interesting approach seeing grid-layout again. It can be highly valuable when creating complex layouts, however I believe that flex-box is supperior and easier to use (at least from the standpoint of my abilities with it). Also, I suspect you might find the font-size a little big. If you do, let's consider that we have/ had a wrong (or at least unadjusted) application wide default font-size to begin with -> perhaps we should increase the font-size in general and keep in mind that the screen will be used in big classrooms.

image (I think it looks adequat though!)

Lastly, let's stick to using scss, because why not? It offers more features than plain css.

Reviewer's task:

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
screenario-react ✅ Ready (Inspect) Visit Preview Aug 24, 2022 at 0:55AM (UTC)
liam-k commented 2 years ago

Looking good, thank you.

In terms of font size – you’re right, lol. If I understand the use case correctly, screenario will be mirrored to a TV or something, but not everything needs to be huge, only things which the group needs to see, because the instructor will still use his or her laptop to use the tool – correct? I’d say the font size shouldn’t be exaggerated unless it’s something the group/audience needs to see. In this case, the font size is almost comical in comparison to other tools. Also, if we want to increase font size globally, we don’t need to increase it this much in the sound board. I’d dial it back to the default font size (no setting via css) and later adjust it globally (or even make it user-adjustable down the road).

image
s-gbz commented 2 years ago

This wasn't a great merge since the actual problem (namely the text being to small) is not solved :neutral_face: Dialing it down a fex pixels would've been okay, but leaving it at the default font is really unsatisfactory.

Would you like to create the appropriate issue and implement it's solution then @liam-k ?

liam-k commented 2 years ago

Sorry, I thought we had agreed on managing the font size via mui theme over Signal? Anyway, I think it still fits – the merge it’s called "responsify soundboard" and it’s responsive now. As I understood it, the client was unsatisfied with font sizes in multiple locations, so it’s less work for us to manage it globally anyway.