search

ISH-Gruppe / screenario

Screenario - The screen for every scenario
https://screenar.io
GNU General Public License v3.0
2 stars 2 forks source link

Users claim that NamePicker is malfunctioning #87

Closed s-gbz closed 2 years ago

s-gbz commented 2 years ago

Clients told me that names which are supposed to be sorted out reappear in drawings. -> Check and confirm or deny the claim

s-gbz commented 2 years ago

@liam-k can you verify this?

liam-k commented 2 years ago

Unfortunately I could – apparently this issue comes up when you minimize and maximize the window again. After that it behaves quite erratically, deleting names (or is that expected behavior) and then bringing names back sometimes.

In general, it seemed to work fine for me if you made changes to the name list, but if you just delete the whole list and then minimize the window, it comes back after reopening. Likely a state/rerendering issue. Maybe you need to specifically clear/update the state when the component is unmounted (onUnmount/componentWillUnmount)– or reorganize how the state is managed.

https://user-images.githubusercontent.com/34057943/186949898-94d06f39-a411-499b-804b-3a2e4d7f87b6.mov

s-gbz commented 2 years ago

Oh man, how did we let that one slip by -> Check out 69922d4d5a918fcf73610aa3315e9f21ad2e1123