ISI-MIP / isimip-qa

ISIMIP Data Quality Assessment
MIT License
3 stars 0 forks source link

Compare input precipitation agains output runoff #8

Open jochenklar opened 1 year ago

jochenklar commented 1 year ago

This issue references the following user stories:

jochenklar commented 1 year ago

Adding @hmschmie

thiasB commented 1 year ago

To my understanding: As a creator of the tool, input and reference data shouldn't differ much in the demand and spectrum of possible comparisons. That's why I'm im favor of treating them the same more or less generic way. Distinguishing both only adds unnecessary complexity an code duplication. In the end the tool has to be used wisely by also acknowledging that not every test need to make sense on every (reference) data/variable relation.

hmschmie commented 1 year ago

Thanks. For this issue, reference data (observations) are not relevant as here, the relation is solely on already available data at the isimip repository - either input variables and model output; model output against model output or combinations of those for other models. The three user stories just show different aspects of the comparison - 1) internal for model x e.g. with a simple regression, 2) comparing such simple regressions with other model's regression and 3) to add spatial characteristics such as the xy-plots where the points are colored according to different spatial characteristics (as we have seen in the presentation from Sebastian and Thorsten).

For reference data (observations) I totally agree that there needs to be a common understanding of a data format / structure to avoid additional conversion.