search

ISIL-ESTE / Student-Workflow-Organizer

The Workflow Organizer website helps students to organize their academic workload through features such as a dashboard, timeline, reminders, collaboration tools, resource library, progress tracking, and analytics. It also allows users to share and summarize courses and seek project help.
MIT License
47 stars 21 forks source link

Feat/migrate tsoa #155

Closed muttaqin1 closed 1 year ago

muttaqin1 commented 1 year ago

This pull request will partially resolve #150.

Any suggestions regarding the code improvement will be accepted gladly.

bellaabdelouahab commented 1 year ago

okay, should I wait for this to be merged or submit another pr

muttaqin1 commented 1 year ago

okay, should I wait for this to be merged or submit another pr

Wait. I will complete this tomorrow insha allah.

muttaqin1 commented 1 year ago

@bellaabdelouahab

muttaqin1 commented 1 year ago

here is my review . note: you havent revoke the user_controller.ts ?

But i have deleted that commit then force pushed the changes. @bellaabdelouahab

bellaabdelouahab commented 1 year ago

But i have deleted that commit then force pushed the changes. @bellaabdelouahab But that is not how to fix it you deleted the commit but the changes are still on other commits after it The way to do it is revok changes on the file

bellaabdelouahab commented 1 year ago

@muttaqin1

bellaabdelouahab commented 1 year ago

I will push mine after i merge @muttaqin1

muttaqin1 commented 1 year ago

I will push mine after i merge @muttaqin1

Okay