ISISComputingGroup / IBEX

Top level repository for IBEX stories
4 stars 2 forks source link

Add Calculation Method and Time Channel File to DAE tab #1274

Closed FreddieAkeroyd closed 7 years ago

FreddieAkeroyd commented 8 years ago

Next to "Time Unit" in the DAE time channels panel should be

Calculation Method Time Channel File

The relevant back end support for these seems to be already in the client, it is just not possible to set them from the GUI

The reason why NDXDEMO cannot see spectra is because it is set to a calculation method of "file" and there is no way to change this from the GUI! Not sure how it got this way, the filename it is trying to use is mantid_py.bat which was also displayed as a period file.

kjwoodsISIS commented 8 years ago

It is unlikely that a user will need to change this setting, so rather than expose it to users, it might be better to add it the Properties dialog (visible to support team, not users). That way, on the rare occasions that it might need to be changed, the support team can change it.

ThomasLohnert commented 8 years ago

Related pull requests: https://github.com/ISISComputingGroup/EPICS-ioc/pull/47 https://github.com/ISISComputingGroup/EPICS-isisdae/pull/6 https://github.com/ISISComputingGroup/ibex_gui/pull/261

John-Holt-Tessella commented 8 years ago

Review: Checking on some implementation details with @FreddieAkeroyd

John-Holt-Tessella commented 8 years ago

Change requests after talking with Freddie and Thomas:

  1. Make Calc method a radio buttons selection
  2. Make labels Use TCB File and Specify Paramters
  3. On radio button change hide appropriate controls
    1. Display for Use TCB Control: time unit and file path
    2. Display for specify parameters: time unit and time regime group box
  4. Change in time regimes group box first drop down from TCB File to blank
  5. Diasallow typing in all drop downs where files can be selected (tcb file, 3 table files and period file)
  6. Make send changes button read apply changes
  7. Create a discard change button which will reset the value back to those on the server
  8. Enable/disable buttons when there are no changes (this might be hard don't do if it is hard)
ThomasLohnert commented 8 years ago

Have now pushed changes that implement all these points apart from:

7.Create a discard change button which will reset the value back to those on the server 8.Enable/disable buttons when there are no changes (this might be hard don't do if it is hard)

Would argue that this is out of scope and should be a separate ticket as the apply/discard changes buttons are associated to all changes in experiment setup including data acquisition and period settings, not just time channels.

AdrianPotter commented 8 years ago

Slight rework of drop downs requested. Currently not clear when drop downs are empty where the GUI is expecting to get files from. Would be good to point users at the correct location in this case and have a tooltip explicitly stating where files are expected.

Note that the changes for this ticket will break the current system tests as the context for setting up the table files puts the files in the wrong place from the GUI's point of view. These will need fixing before the ticket can be marked complete.