ISISComputingGroup / IBEX

Top level repository for IBEX stories
5 stars 2 forks source link

Web Dashboard: Value formatting #2069

Closed DominicOram closed 6 years ago

DominicOram commented 7 years ago

As an POLARIS and IRIS instrument scientists I want the dashboard to show small numbers the same as the IBEX dashboard, not to truncate them. This is caused by the archiver json representation of the value which is truncated using the epics precision. We need to update this and then change the formatting rules in JSON Borne.

Ian found a couple of minor formatting issues on the web dashboard:

The “Monitor From” and “Monitor To” are showing 3 decimal places, which is unnecessary, and the vacuum gauges (mostly a problem for the bin vac) are showing linear scale. For these it would be better reported as an exponent.

DominicOram commented 7 years ago

For the exponent issue we have recently added formatting rules to the GUI, these should probably be followed in the web dashboard.

DominicOram commented 7 years ago

This is especially bad when the value is very low. Ian saw values at 1e-7 reported as 0.000

Tom-Willemsen commented 7 years ago

POLARIS have also reported that this truncation happened to some of their numbers, causing some confusion.

Apparently a furnace_vac block displayed as 0.000...on the web dashboard when the real value was 0.0005. (Number of zeroes is illustrative only)

Inform Ron/Helen on POLARIS when this ticket is done as they seemed quite keen for this to be fixed.

John-Holt-Tessella commented 7 years ago
Tom-Willemsen commented 6 years ago

Raised again by HRPD in their demo today.

DominicOram commented 6 years ago

I've modified the archive engine to give non-formatted values and precision in the JSON. Please review as part of this ticket.

Code changes at: https://github.com/ISISComputingGroup/cs-studio/compare/master...ISISComputingGroup:archive_engine_json_formatting_2265

Built version is at \isis\inst$\Kits$\CompGroup\ICP\archive_engine_with_json To test built version:

Once reviewed we need to:

DominicOram commented 6 years ago

Moving to impeded as new ArchiveEngine doesn't work on some machines, will look into before finishing ticket

Tom-Willemsen commented 6 years ago

The archive engine on the share (compgroup\icp\archive_engine_with_json) should work but is hotfixed. Dom is doing ticket https://github.com/ISISComputingGroup/IBEX/issues/3206 to document how to build it sensibly.

John-Holt-Tessella commented 6 years ago

Rework:

Run whole thing together.

DominicOram commented 6 years ago

@John-Holt-Tessella New archive engine build on share. Does it work for you?

John-Holt-Tessella commented 6 years ago

Yes it works