Closed KathrynBaker closed 7 years ago
Acceptance criteria:
Once the PRs have been reviewed, please put back in ready. The PRs fix a couple of issues with the LinMot needed for deployment to HRPD. Whilst that's happening, I'll create a test plan and communicate it with the HRPD instrument scientists.
HRPD test plan
Assuming these tests match then we are sufficiently confident that the motor is behaving as expected.
Please ensure to explain the major differences between the old and new setups to the instrument scientists:
For review:
Once reviewed, please move back to ready and I'll do the following:
Is it worth getting Gareth or David to review the test plan too? Looks good to me though.
Sent to Gareth and David. David has given it the thumbs up. No reply from Gareth yet.
Awaiting
I've deployed the new build version to HRPDTEST. The motors are set up correctly in simulate mode*. Dominic has approved the test plan.
*For simulated motors, using multiple axes operates as one motor. All 4 axes share the same values. This is a new issue and I've noted the same things happen with the McLennan in devsim mode. I'll create a separate issue to look at it.
Test plan enacted as specified (although we switched to configuration slightly early). Numbers all match between VI and EPICS within rounding and tolerance: Velocities all checked.
Initial position
dir | IBEX | VI |
---|---|---|
N | 9.991 | 9.99 |
S | 9.991 | 9.99 |
E | 7.508 | 7.51 |
W | 7.508 | 7.51 |
Moved in VI
dir | IBEX | VI |
---|---|---|
N | 7.893 | 7.90 |
S | 8.008 | 8.00 |
E | 5.005 | 5.00 |
W | 5.101 | 5.1 |
Velocities checked all 52
Move in IBEX
dir | IBEX | VI |
---|---|---|
N | 8.1 | 8.10 |
S | 7.7 | 7.70 |
E | 4.79 | 4.79 |
W | 5.20 | 5.2 |
Got upper and lower limit violations when set.
The code to allow this was merged as part of #2098, however the jaws still need to be set up on HRPD and checked as this was tested with a test system not the actual jaws. This could not be done prior to the other ticket being completed.
There are two jaw sets with the following information to consider when adding the commissioning on HRPD:
Set 1
Calibration: 0.01925 steps/mm
Offsets:
Set 2
Calibration: 0.01953125 steps/mm
Offsets: