ISISComputingGroup / IBEX

Top level repository for IBEX stories
5 stars 2 forks source link

Web dashboard: Title, users and values are truncated #2316

Closed AdrianPotter closed 6 years ago

AdrianPotter commented 7 years ago

Reported by Helen Playford on Polaris.

On the web dashboard, the title and users are being truncated:

image (ALF)

image (Polaris)

It appears that there may be some encoding issue. This has been observed both on Alf and Polaris. The current title and user on Polaris is:

image

There's no obvious reason why this shouldn't be able to be displayed. There are no special characters in either the title or users.

Acceptance Criteria:

  1. Blocks can be viewed
  2. Title and user are not truncated
  3. Errors are displayed for blocks in error (and only blocks in error)
  4. Title and User name values are marked as unavailable unless the show title box on the DAE tab is ticked
DominicOram commented 7 years ago

The underlying cause of this is that the archive engine webpage (that we are using to get the title/username) truncates the data. We will have to get the data from somewhere else, SQL? EPICS? then serve it via the JSON the blockserver is sending to the web dashboard.

DominicOram commented 7 years ago

Note that this was originally reported in https://github.com/ISISComputingGroup/IBEX/issues/1627. I will close that one as this is better defined.

Tom-Willemsen commented 7 years ago

POLARIS have also reported that this truncation happened to some of their numbers, causing some confusion.

Apparently a furnace_vac block displayed as 0.000...on the web dashboard when the real value was 0.0005. (Number of zeroes is illustrative only)

Inform Ron/Helen on POLARIS when this ticket is done as they seemed quite keen for this to be fixed.

DominicOram commented 7 years ago

@Tom-Willemsen I think that should be a separate issue as I think they might have quite different causes/solutions. The truncation of values has already been noted in https://github.com/ISISComputingGroup/IBEX/issues/2069

Tom-Willemsen commented 7 years ago

OK, will copy my comment over to that ticket.

kjwoodsISIS commented 7 years ago

Plan for resolving this problem will be determined by outcome of #2463

Tom-Willemsen commented 7 years ago

Requires #2477

John-Holt-Tessella commented 7 years ago

Pull request https://github.com/ISISComputingGroup/JSON_bourne/pull/20

John-Holt-Tessella commented 7 years ago

This has utf8 issues see #2728 for ticket to fix this.

kjwoodsISIS commented 7 years ago

Are we saying this ticket is now dependent on #2728? (i.e. it impeded until #2728 is completed?)

John-Holt-Tessella commented 7 years ago

No, this ticket can be merged when done and I am hoping will provide the functionality for most use cases. However #2728 is a separate important fix that needs to be done at some point.