ISISComputingGroup / IBEX

Top level repository for IBEX stories
5 stars 2 forks source link

IOC: Precision and alarms for Danfysiks #2935

Closed John-Holt-Tessella closed 6 years ago

John-Holt-Tessella commented 6 years ago

As a MUONFE instrument scientise I would like the precision of the current and voltage to be 3. I would also like alarm limits (minor and major) that I can set and that will be remembered between restarts. This is already implemented on MUONFE.

Write tests and check into repo.

John-Holt-Tessella commented 6 years ago

Changes made are:

diff --git a/ioc/master/DFKPS/db/DFKPS_common.db b/ioc/master/DFKPS/db/DFKPS_common.db
index 66122bde8..94238cb6b 100644
--- a/ioc/master/DFKPS/db/DFKPS_common.db
+++ b/ioc/master/DFKPS/db/DFKPS_common.db
@@ -54,9 +54,12 @@ record(calcout, "$(P)VOLT")
     field(CALC, "A * $(FRV)")
     field(INPA, "$(P)VRAW")
     field(EGU, "V")
-    field(ASG, "READONLY")
     info(INTEREST, "HIGH")
+    field(HSV, "MINOR")^M
+    field(LSV, "MINOR")^M
+    field(PREC, "3")^M
     info(archive, "VAL")
+    info(autosaveFields, "HIGH LOW")^M
 }

 alias("$(P)VOLT", "$(P)VOLT:RBV")
@@ -66,6 +69,7 @@ record(ao, "$(P)CURR:SP")
     field(DESC, "Set Current")
     field(DTYP, "Soft Channel")
     field(OUT, "$(P)CURR:TORAW.A PP MS")
+    field(PREC, "3")^M
 }

 record(calcout, "$(P)CURR:TORAW")
@@ -134,9 +138,12 @@ field(CALC, "A * $(FRI)")
 field(INPA, "$(P)RAW")
 field(FLNK, "$(P)FIELD:PRECALIB")
 field(EGU, "A")
-field(ASG, "READONLY")
+field(HSV, "MINOR")^M
+field(LSV, "MINOR")^M
+field(PREC, "3")^M
 info(INTEREST, "HIGH")
 info(archive, "VAL")
+info(autosaveFields, "HIGH LOW")^M
 }
 alias("$(P)CURR", "$(P)CURR:RBV")

diff --git a/ioc/master/TDK_LAMBDA_GENESYS/db/TDK_Lambda_Genesys.db b/ioc/master/TDK_LAMBDA_GENESYS/db/TDK_Lambda_Genesys.db
index 556e8c9ae..9a7256a5e 100644
--- a/ioc/master/TDK_LAMBDA_GENESYS/db/TDK_Lambda_Genesys.db
+++ b/ioc/master/TDK_LAMBDA_GENESYS/db/TDK_Lambda_Genesys.db
@@ -72,6 +72,10 @@ record(ai, "$(P)VOLT") {
     field(SIOL, "$(P)SIM:VOLT")
     field(SDIS, "$(P)DISABLE")
     field(EGU,  "V")
+    field(HSV, "MINOR")^M
+    field(LSV, "MINOR")^M
+       field(PREC, "3")^M
+    info(autosaveFields, "HIGH LOW")^M
     info(INTEREST, "HIGH")
     info(archive, "VAL")
 }
@@ -86,6 +90,7 @@ record(ao, "$(P)VOLT:SP") {
     field(SDIS, "$(P)DISABLE")
     field(EGU,  "V")
        field(PINI, "$(SP_PINI)")
+    field(PREC, "3")             ^M
        info(autosaveFields, "VAL")
 }

@@ -97,6 +102,7 @@ record(ai, "$(P)VOLT:SP:RBV") {
     field(SIML, "$(P)SIM")
     field(SIOL, "$(P)SIM:VOLT:SP:RBV")
     field(SDIS, "$(P)DISABLE")
+    field(PREC, "3")             ^M
     field(EGU,  "V")
 }

@@ -117,6 +123,10 @@ record(ai, "$(P)CURR") {
     field(SDIS, "$(P)DISABLE")
     field(EGU,  "A")
     info(INTEREST, "HIGH")
+    field(HSV, "MINOR")^M
+    field(LSV, "MINOR")^M
+       field(PREC, "3")^M
+    info(autosaveFields, "HIGH LOW")^M
     info(archive, "VAL")
 }
@@ -130,6 +140,7 @@ record(ao, "$(P)CURR:SP") {
     field(SDIS, "$(P)DISABLE")
     field(EGU,  "A")
     field(PINI, "$(SP_PINI)")
+    field(PREC, "3")             ^M
     info(autosaveFields, "VAL")
 }

@@ -142,6 +153,7 @@ record(ai, "$(P)CURR:SP:RBV") {
     field(SIOL, "$(P)SIM:CURR:SP:RBV")
     field(SDIS, "$(P)DISABLE")
     field(EGU,  "A")
+    field(PREC, "3")             ^M
 }

 record(ao, "$(P)SIM:CURR"){