search

ISISComputingGroup / IBEX

Top level repository for IBEX stories
5 stars 2 forks source link

Danfysik: Set multiple values at the same time #3848

Open ThomasLohnert opened 5 years ago

ThomasLohnert commented 5 years ago

As a Muon scientist, I want to be able to set multiple values on power supplies at the same time. This may require a higher level OPI with a "set" button which sends values entered in relevant text boxes to the SPs instead of setting the SPs individually when you hit enter on the text entry field. Fix is applied to normal and daisy chained Danfyiks

John-Holt-Tessella commented 5 years ago

We should try not to do this in most cases because it breaks the IBEX convention that pressing return send the value to the device. If we do implement it this logic should be placed into the IOC, I suggest we start a pattern for this. We need to find out if in the scripts they expect the value just to be sent and it is only in the GUI where they want a set. if so the reflectometry pattern is:

XXX - read back XXX:SP - set the value immediately XXX:SP:RBV - the value that the device has as a setpoint XXX:SP_NO_MOVE - don't set the value but wait (this is a temporary value if you restart the IOC it is lost) XXX:MOVE - now take the SP_NO_MOVE and send it to the device

If this is going to be a general pattern NO_MOVE and MOVE don't make sense can someone think of better terms.

Kevin-Woods-Tessella commented 5 years ago

How about NO_ACTION and ACTION? Or SUSPEND and RELEASE?

John-Holt-Tessella commented 5 years ago

Should I update reflectometry to follow action/no_action convention?

kjwoodsISIS commented 5 years ago

I guess it is probably easier to make the change now, rather than re-visit it at some later point. Hopefully it should be a simple global change.

John-Holt-Tessella commented 5 years ago

Written up in https://github.com/ISISComputingGroup/ibex_developers_manual/wiki/ISIS-PV-Guide