search

ISISComputingGroup / IBEX

Top level repository for IBEX stories
5 stars 2 forks source link

Triton: behaviour on switching to/from closed loop mode #4103

Closed Tom-Willemsen closed 5 years ago

Tom-Willemsen commented 5 years ago

As an LET instrument scientist I want the Triton system to behave correctly in closed loop mode.

From LET scientist:

The user wanted to warm the dilution to 0.3k so we put the value in the set temperature box and nothing happened. I found out that you then have to press a button for closed loop on. Again this should be automatic and the user should not have to see this as it was on SECI. You just want to give the temperature and that’s it. After turning closed loop on nothing happened still. It then turns out we have to tell it where to get a PID file in another tab. I did this and it finally started working. I then changed something in the blocks and found I could not change temperature again. It turns out it had now turned the closed loop off and lost the PID file so I had to go and put it all in again. It seems its like with the collimator that when you do anything in the blocks it forgets everything and you have to restart it all.

We should clarify exactly what the oxford triton software does when set to closed loop mode - I think it may reset the setpoint to the current temperature, but this needs testing.

Also test that the PID file is preserved on IOC restart - this applies to all the drivers that use ReadASCII (e.g. would also apply to Eurotherm)

John-Holt-Tessella commented 5 years ago

We need to decide whether the PID file and closed loop should be autosaved or a setting in the macros I do not know which make sense here.

Tom-Willemsen commented 5 years ago

On checking the labview driver, it ALWAYS sets closed loop mode on when any temperature is set. The IOC should also do this.

Tom-Willemsen commented 5 years ago

To do as part of this ticket:

These changes would be good to get in in time for an experiment on LET 22/3/2019

Tom-Willemsen commented 5 years ago

PRs:

Tom-Willemsen commented 5 years ago

Switching PID files from config: worked ok on actual hardware on LET

Turning closed loop mode on whenever temperature is set: on real triton fridge on LET, turning closed loop on/off makes the fridge reset it's temperature setpoint to the current temperature. This caused very odd behaviour with the changeset above, so I removed it again. There is a meeting scheduled with cryogenics where I'll ask what we should be doing about closed loop mode ( https://github.com/ISISComputingGroup/IBEX/issues/3993 ). I'll put this in impeded in the meantime.

I think the difference is that the labview sends closed loop on first, then checks it's turned on, and then sends the temperature, whereas the changeset above assumed that tset and closed loop mode were independent. I will try implementing the ordering at the protocol level instead.

Tom-Willemsen commented 5 years ago

Discussed this with cryogenics, there are several additional subtle issues:

Cryogenics will be running a fridge down to low temperature over shutdown, and they will give us an opportunity to test on the real hardware and work with them to try and find the "least bad" solution to this issue. We will then need to apply this solution to both LabVIEW and IBEX drivers.

kjwoodsISIS commented 5 years ago

When all these issues have been investigated and resolved, we must ensure to explain the behaviour of the Triton systems to the scientists, so that they understand what is and is not possible.

Tom-Willemsen commented 5 years ago

Triton fridge NDRI1 will be available for us to test with Tomorrow (17/4/2019).

Tom-Willemsen commented 5 years ago

Tested on a real Triton (NDRI1) with help from cryogenics, a sequence that seems to work ok is: