search

ISISComputingGroup / IBEX

Top level repository for IBEX stories
5 stars 2 forks source link

Jasco pump: organise test with scientist #4269

Open Tom-Willemsen opened 5 years ago

Tom-Willemsen commented 5 years ago

As an instrument scientist, I want to be sure that the JASCO driver will work with my existing scripts.

We have written an IOC and Labview wrapper VI, the scientists would like to run a test to ensure that the pump works properly with their scripts.

In particular, test that the pump can be started and runs forever without explicitly entering a large time value.

kjwoodsISIS commented 5 years ago

It would have been better to know of this requirement ("pump runs forever") before the fact. Nevertheless, can we please check that this is the case before we run the test and, if not, change the behaviour. In fact, it would be worth asking the scientist to provide a copy of his script, so that we can see how the pump is controlled.

John-Holt-Tessella commented 5 years ago

This is part of the generic timing driver for HPLC pumps and should be fixed by #4143 which fixes it on the Knaur. However, the code is repeated between the support modules and will need to be copied into the JASCO. I suggest that as part of this ticket the generic part of the code is separated out and put in its own support module which is used by both pumps.

DominicOram commented 5 years ago

Is this still required?