ISISComputingGroup / IBEX

Top level repository for IBEX stories
5 stars 2 forks source link

IOC: CRISP Flipper system #5338

Closed John-Holt-Tessella closed 4 years ago

John-Holt-Tessella commented 4 years ago

As an instrument scientist I want to run a polarised neutron experiment, this means I need to coordinate a kepco and spin flipper.

Acceptance Criteria

Notes

See vi: ...\LabVIEW Modules\Large Scale Structures\CrispAnalyzerStage\Flip Field - Flipper and Kepco.vi

Connection appears to be 9600, 8 bits 1 stop bit no parity

It looks like you trigger the main vi which sets the flipper either up or down and kepco voltage similarly. The voltage and current are constant. Then you set the flipper to down. But see vi.

I think easiest to do is create the flipper as an IOC and write a script to do the coordination.

KathrynBaker commented 4 years ago

It might be easiest to write a script – but this could be a continuously running script, and it may be more usable and sustainable to put the logic for the control in the IOC, or in an IOC at least – I don’t think we would want it reliant on anything else to function if we can avoid it.

FreddieAkeroyd commented 4 years ago

Can this logic be done in lua or snl? If this is a piece of equipment controlling both a flipper and a kepco, and it makes sense to bind them together, then an ioc can be created with device support for both

John-Holt-Tessella commented 4 years ago

I think the actions that are needed are set kepco voltage, set flipper direction, set flipper to down.

It looks like this was just triggered from an open genie script. So they already need a script that does everything but this. I should get hold of that script and see what it looks like.

If this is the case I think that a script will suffice. I will double check with the scientists what their current script does.

Tom-Willemsen commented 4 years ago
John-Holt-Tessella commented 4 years ago

Sorry my fault I said above I would contact the scientists to ask about the coordination and I haven't. Let me do that now.

Tom-Willemsen commented 4 years ago

Coordination logic split into https://github.com/ISISComputingGroup/IBEX/issues/5415

adalator commented 4 years ago

Rework summary:

DominicOram commented 4 years ago

Leaving to @Tom-Willemsen to re-review but assigning to myself for timebeing