Split Char Waveform: FTE still required when using mode 1 - Githubissues

ISISComputingGroup / IBEX

Top level repository for IBEX stories

5 stars 2 forks source link

Split Char Waveform: FTE still required when using mode 1 #5764

Closed DominicOram closed 2 years ago

DominicOram commented 4 years ago

As a developer I would like the splitCharWaveform asub function(https://github.com/ISISComputingGroup/EPICS-asubFunctions/blob/master/asubFunctionsApp/src/splitCharWaveform.c) to be easier to use. Currently it's behaviour switches based on the mode flag. If the mode is 1 then INPE is not used but it still throws an error if FTE is not ULONG. The function could also use some more documentation/tests.

Acceptance Criteria

FTE does not always have to be specified
There are automated tests on the function
There is some documentation in the wiki pointing to where to find out more about the function

Scott-James-Hurley commented 2 years ago

Release notes: https://github.com/ISISComputingGroup/IBEX/pull/7310