ISISComputingGroup / IBEX

Top level repository for IBEX stories
4 stars 2 forks source link

SANS2D: collision avoidance: alternative solution for fast deceleration #5894

Closed Tom-Willemsen closed 2 years ago

Tom-Willemsen commented 3 years ago

On testing https://github.com/ISISComputingGroup/IBEX/issues/5735 with real hardware, it became apparent that we can't actually do a fast deceleration on a specific galil axis (or at least, not easily).

Acceptance criteria

DominicOram commented 2 years ago

See https://github.com/ISISComputingGroup/IBEX/issues/5735#issuecomment-712911230 for a better description of the problem

rerpha commented 2 years ago

Meeting was had with @RaiBishal, @rerpha, @davidkeymer, @JackEAllen, @KathrynBaker, @JamesKingWork and @DominicOram. Meeting notes:

Firstly, we don't think decelerating before a collision worked because the motor record can't do it and also the Galil won't accept a command before finishing a move - it will just queue the deceleration speed change and apply to the next move.

SANS2D want the SECI way of doing it rather than decelerating before a collision - they want users to set all moves then send after figuring out if something will not collide.

The table of motors does not need to obey the collision avoidance stuff - it is a manual control that should be able to override it.

We need to discuss all of this with the scientists to make sure it fits their requirements.

See https://github.com/ISISComputingGroup/IBEX/issues/6785

In this meeting we also decided to do https://github.com/ISISComputingGroup/IBEX/issues/6786

rerpha commented 2 years ago

Can confirm meeting was had and that the ticket covers the method/requirements we discussed