ISISComputingGroup / IBEX

Top level repository for IBEX stories
5 stars 2 forks source link

Beckhoff: Automation tools silently fail to build plc solution #6817

Open rerpha opened 3 years ago

rerpha commented 3 years ago

Where?

We discovered that if the PLC_solution folder of BeckoffTestRunner has not recursively pulled the submodules (ie. tca_std_lib) the automation tools won't fall over, despite not generating a .tpy file. We should make the automation tools spit out an error if this occurs as everything looks fine. The old AutomationTools used to complain if it couldn't build the solution so we should make TwincatAutomationTools do the same.

Reproducible?

Yes

To Reproduce

clone beckhoff test runner and just use git submodule update --init without the recursive flag try and run build.bat notice that it doesn't break! and falls over silently, the ioc tests subsequently fail

Acceptance criteria

rerpha commented 3 years ago

We used to do this here: https://github.com/ISISComputingGroup/BeckhoffTestRunner/commit/3993ab0057e3e759457945c8cfe619af9c4cca8b#diff-1ac210987884d765a8d1a5af5e9af5d72525bfabe89899cc9e96416ad3b7cb36L27