Reflectometry: Confirm redefining positions

[ThomasLohnert]

As a reflectometry scientist, I would like some adequate controls to be in place to protect me from errors on redefining positions. At the moment, as soon as you enter a new value on the redefine dialog and press "enter", the motor position is redefined. This could lead to user error, especially as it is different to the rest of the reflectometry server, where you still have to push the "move" button to actually set a new value on an axis, which gives users of the OPI an extra opportunity to verify the new value and protect against typos, typing in the wrong field etc. Recovering from such an error is slightly awkward as you either have to remember the previous value, or go look it up in the archive.

Acceptance Criteria

There is a validation step after entering a new position to which you want to redefine an axis. e.g.:

• Add SP / SP:RBV / ACTION fields for each redefine parameter value, similar to the regular parameter SP / SP:RBV / ACTION fields

or

• Add a confirmation dialog that pops up after you enter a value in the text box (not sure whether this is easily doable on an OPI)

How to Test

verbose instructions for reviewer to test changes (Add before making a PR)

[ThomasLohnert]

Looks good overall! I have got a couple of suggestions for making the interactions a bit more robust:

• The server does not seem to like it at all when you redefine position for an axis in the middle of a move (e.g. breaks the readback value and entering more values seems to become a bit temperamental). This is not something I would expect users ever wanting to do intentionally as it makes it extremely difficult to determine how much they have actually offset an axis by redefining it. Therefore I would suggest preventing users from doing this with one of the following solutions:
  • Ideally, set .DISP on DEFINE_POS_SP and DEFINE_POS_ACTION while a parameter is moving (indicated by its "changing" flag)
  • If it turns out this is really awkward to do, at least add a rule on the Move button so that it is disabled while the parameter is "changing"
• The Move button for actually moving (not redefining) an axis to a different position does not work when the component for this parameter is parked out of beam. This should be reflected by replacing the button with an "out" label, same as we do on the normal parameter tabs

Some other minor comments on individual PRs