search

ISISComputingGroup / IBEX

Top level repository for IBEX stories
5 stars 2 forks source link

Update Beckhoff tcIOC to hopefully fix issues with new format TPY file #7344

Closed FreddieAkeroyd closed 1 year ago

rerpha commented 2 years ago

https://github.com/ISISComputingGroup/IBEX/pull/7347

~Just running BeckhoffTestRunner tests on my machine now, if successful this means #7329 is less of a pressing issue as TPY loading for twincat v4024.20+ is fixed.~

rerpha commented 2 years ago

ok, 4024.32 still does not work still but i have diffed the two and can see what's missing from the newer standard - unsure whether it's a bug in beckhoff or just the way the new standard works, but will try and find out. Tests still pass if built on 4024.11 which our bat files do so we should still merge in the vendor branch i think

rerpha commented 1 year ago

~Going to pull back in progress as I am just trying to find out why it doesn't like 4024.32 TPY - 4024.11 still works~

realised after a fair bit of debugging i was looking at master not your branch... whoops! seems to work for 4024.32 and 11, but just double checking to make sure

rerpha commented 1 year ago

it does not like the types in the tpy which are now missing decorators

rerpha commented 1 year ago

going to be a bit cheeky here and merge the update branch in as i have technically been reviewing this change by testing it. 4032.24 works, but our build tools have broken for the latest plc code, though this is not in our control. we should test against the next release of the plc code as soon as it comes out, but this should mean that we can keep up with the future commissions. updating tcioc means 4024.11 still works as well.