rerpha
commented
1 year ago I think an upgrade step is overkill for this as the beckhoff instruments (SANS2D, LARMOR and IMAT) need reconfiguring anyway which is a manual process (i will do this when deploying) and the SANDALS pt100s are due to change so i won't do them in this ticket and instead add them to motorextensions in #6097
PRs:
- motorextensions: https://github.com/ISISComputingGroup/EPICS-motorExtensions/pull/48
- RNs: https://github.com/ISISComputingGroup/IBEX/pull/7540
I have updated https://github.com/ISISComputingGroup/ibex_developers_manual/wiki/Beckhoff-commissioning#arbitrary-fields as well
This is a fairly difficult one to review. SANS2D and LARMOR have a tc_project_app.tpy file, and corresponding db file, in their settings\twincat directory. The DB file should contain the names of the extra fields ie. BAIRPLC for LARMOR and FTORQUEACTUALetc. for SANS2D. This should match up with AUX.bAirPLC and AXIS_x.fTorqueActualAxisx for LARMOR and SANS2D respectively. There are two things to check here:
- PV names match up to what's currently on LARMOR and SANS2D (check tc_project_app.db and check for anything that is not prefixed by
TC_01:ASTAXES_ - PLC var names are found (use notepad++, its just an xml file) in the TPY and match up to the INP field in the new motorextensions records
Tom-Willemsen
SANS2D and LARMOR have some extra fields in their beckhoff that they expose, currently through a TPY along with the rest of the motion fields.
As we have now switched to a method that doesn't use the TPY file any longer, these fields need to be manually added and loaded in by some motorExtensions db files instead. we should create these and deploy/patch them on to save having to do this on the fly.
The reason we should use motorExtensions is that if something needs to be changed globally it's much easier to do this in motorExtensions then just deploy, than try and edit each instance in the settings area/modify them with an upgrade script.
Acceptance criteria