Aeroflex Signal Generator - Add Units to PVs

ISISComputingGroup / IBEX

Aeroflex Signal Generator - Add Units to PVs #7876

Open davidkeymer opened 1 year ago

davidkeymer commented 1 year ago

As an instrument scientist, I would like units to be displayed on blocks created from the 'Frequency' and 'RF Level' PVs on the Aeroflex signal generator OPI.

Acceptance Criterion

Units are added to the appropriate PVs

Notes

See ticket for removing unit selection for frequency, and/or fixing at MHz (ideally complete first)
Will need to update the .EGU fields dynamically if frequency unit selection is removed
RF level has fixed dBm units on OPI, but not displayed on block

danielmaclaren commented 1 year ago

I completed the ticket, only to find out from Steve Cottrell that the changes have already been made and are currently on the Aeroflex!

I've moved the ticket to review, unsure what the pull request was however and it's unknown who carried out the changes.

FreddieAkeroyd commented 1 year ago

Maybe it was done as part of https://github.com/ISISComputingGroup/IBEX/issues/7879 which would have been in the recent deploy