ISISComputingGroup / IBEX

Top level repository for IBEX stories
5 stars 2 forks source link

web dashboard/DAE: show "disabled" rather than "unavailable" when users and title hidden #7923

Closed rerpha closed 1 year ago

rerpha commented 1 year ago

As a user I would like the web dashboard to be more helpful and say "disabled" or "hidden" (and if possible, a tooltip on how to show/hide it)

Curently if you go into the GUI and hide the users/title from the web dashboard it then just says "Unavailable" on the web dashboard with no explanation as to why they are unavailable.

Acceptance criteria

rerpha commented 1 year ago

may be a case of just changing https://github.com/ISISComputingGroup/JSON_bourne/blob/master/external_webpage/instrument_information_collator.py#L98C22-L98C33 but I didn't want to hotfix as I know there are some http/https things going on with json bourne atm!

rerpha commented 1 year ago

https://github.com/ISISComputingGroup/ibex_developers_manual/wiki/Web-Dashboard#developmenttesting for instructions on spinning up your own json_bourne webserver

FreddieAkeroyd commented 1 year ago

All changes to json bourne are now pushed to git, so you should be able to deploy a new master (or a branch so long as you have merged recent master)

rerpha commented 1 year ago

https://github.com/ISISComputingGroup/JSON_bourne/pull/57 5 min change, should really be a flash review

rerpha commented 1 year ago

ps softmat has users hidden for testing/reviewing