ISISComputingGroup / IBEX

Top level repository for IBEX stories
4 stars 2 forks source link

deploy script: directory backup script ignores the ignore list #8186

Closed FreddieAkeroyd closed 5 months ago

FreddieAkeroyd commented 6 months ago

A backup during a deploy failed with

PermissionError: [WinError 5] Access is denied: 'C:\\Instrument\\Settings\\$RECYCLE.BIN\\S-1-5-21-1529648298-3970

This directory is passed to the ignore list https://github.com/ISISComputingGroup/ibex_utils/blob/96a53f316a6f43ccdacefceb9a3cdc70ceaff5ee/installation_and_upgrade/ibex_install_utils/tasks/backup_tasks.py#L132 but it is not passed on to the actual file move/copy function https://github.com/ISISComputingGroup/ibex_utils/blob/96a53f316a6f43ccdacefceb9a3cdc70ceaff5ee/installation_and_upgrade/ibex_install_utils/tasks/backup_tasks.py#L101

Acceptance Criteria

isaachilly commented 6 months ago

PRS

FreddieAkeroyd commented 5 months ago

Thanks @isaachilly