search

ISISComputingGroup / IBEX

Top level repository for IBEX stories
4 stars 2 forks source link

Deploy Script: fails to invoke git updater if Git is installed in Program Files #8203

Closed zsoltkebel closed 4 months ago

zsoltkebel commented 5 months ago

Screenshot 2024-01-26 at 09 55 10

Seems like something goes funny with the path to the git executable and the code thinks it's not in Program Files: (The else branch gets executed even though git is in Program Files) Screenshot 2024-01-26 at 10 33 13

LowriJenkins commented 5 months ago

Add test to confirm freddie's patch works

LowriJenkins commented 5 months ago

original issue occured on enginx

danielmaclaren commented 4 months ago

I don't think that adding a test is necessary as well will be testing if os.path.realpath works

zsoltkebel commented 4 months ago

As Daniel mentioned I don't think there is need to test this.