Closed FreddieAkeroyd closed 5 months ago
Looks good - could you patch onto galil-old of ioc\master please, I guess we'll need this there as well
Thanks @rerpha in fact probably more important in galil-old than where it is currently
Just a thought, as I think this works fine for the short term, but perhaps long term we should do something similar to the CCD where we have a baud rate macro which has no default, then do a stringiftest to see if it exists then set up serial comms if so? And allow PORT to either be an IP or COMx
just thinking this might be less confusing for users as they might not be able to decipher the regex
That would be simpler to a user, but ideally a user would not see the regex at all and would just see an example of that to type (an example
attribute in the XML). Having PORT as COM or IP would still be a bit of a horrible regex for a user, i see the CCD has separate PORT and IPADDR macros. I see a bit of an issue using BAUD from a working point of view, we have to say it had no default if we are using it as a check, but then we don't want to make it mandatory as that means COM not IP. So i can see how the mechanism would work, but just our current wording may be a bit confusing.
As a user i would like to be able to type
COM4 38400
as well as192.168.1.1
into theGALILADDR
macroAcceptance Criteria
How to Test
make iocstartups
after swapping branch and then restart server