search

ISISComputingGroup / IBEX

Top level repository for IBEX stories
4 stars 2 forks source link

Refl: revert synchronised velocity setting change #8225

Closed rerpha closed 4 months ago

rerpha commented 4 months ago

After #5607 was implemented we tested with a simulated motor setup and saw very little improvement. After a bit of thought I don;t think setting velo first before moving will be much faster as it's a race against CA which is fairly quick in the real world.

5607 was causing occasional ioc test failures, and for the added complexity I don't think it's worth keeping - the previous way seemed more robust as something could happen between setting velo and moving which may not be covered by those changes.

Acceptance criteria

rerpha commented 4 months ago

https://github.com/ISISComputingGroup/EPICS-refl/pull/55 https://github.com/ISISComputingGroup/IBEX/pull/8226

I'm not going to patch this onto refl instruments as I don't think it will necessarily cause issues, though isn't ideal.

to review check the above branch out in support\refl\master\ , run unit tests (in refl dir) and ioc tests (in ioctestframework support module)