ISISComputingGroup / IBEX

Top level repository for IBEX stories
4 stars 2 forks source link

refl: string constants are not displayed correctly #8227

Closed rerpha closed 4 months ago

rerpha commented 4 months ago

As a reflectometry user I would like to have a string constant and I would like it to be displayed correctly.

Currently these are given a type of "float_type" which causes the GUI to display each character in the char array as hex.

This was noticed yesterday when helping INTER out with adding some string constants, which we noticed weren't displayed correctly.

Acceptance criteria

as you can see in this pic of INTER's constants tab, "OPI" and "slits" are strings that are not displayed correctly.

image
rerpha commented 4 months ago

https://github.com/ISISComputingGroup/EPICS-refl/pull/56 https://github.com/ISISComputingGroup/ibex_gui/pull/1679 https://github.com/ISISComputingGroup/IBEX/pull/8228

To review:

image
Chsudeepta commented 4 months ago

Code reviewed