Mclennan: Allow certain values to be made available to edit without restarting the IOC - Githubissues

ISISComputingGroup / IBEX

Top level repository for IBEX stories

4 stars 2 forks source link

Mclennan: Allow certain values to be made available to edit without restarting the IOC #8284

Closed KathrynBaker closed 2 months ago

KathrynBaker commented 3 months ago

As a scientist using the Mclennan there are times when I want to be able to edit the Jog velocity as well as the high and low limits, as these are not readily editable as the places to change them are non-persisting I would like a macro to let me make this change anyway that can be set in globals.txt.

Acceptance Criteria

[ ] A security group is created that allows for the JVEL, HLM, and LLM to be set or not based on a specific macro which defaults to not allowing changes
[ ] There are tests both with and without that macro set to ensure the beaviour is as expected

Extra Information

Selective access security for certain fields is already present in Mclennans, look at how it's already being done and extend it with macros

How to Test

verbose instructions for reviewer to test changes (Add before making a PR)

Time in planning

1:42:45 4/4/24

isaachilly commented 2 months ago

PRs

To test

Checkout all branches
Check the code's quality
Check tests are written correctly and pass
Set (or don't set) MOTOR_ASG manually in your globals.txt and check functionality by spinning up McLennan IOC using C:\Instrument\Apps\EPICS\support\IocTestFramework\master>run_all_tests.bat -t mclennan -a. Remember to let tests run through before ctrl-c otherwise you have to find the procserve process in task manager details and end that before you can start up the IOC again