As a developer we should be able to use a custom emulator (this is already possible) other than Lewis and after the tests have completed the emulator should close down graciously.
How?
Suppose you want to use a custom emulator for testing IOC. The solution is to use the following tags in the IOCs block:
"emulator_launcher_class": CommandLineEmulatorLauncher,
"emulator_command_line": "responder.bat",
where responder.bat is a bat file that probably calls the simulator exe.
The issue is once the IOC tests are run and the simulator exe is executed, there probably there is no way to close the exe or the cmd window which ran the exe.
The lindy ioc tests run into this issue, but have a rough solution that should be replaced.
Reproducible?
[Yes]
To Reproduce
-Remove kill the emulator from the end of the test bat and then run the lindy IOC test cases
Acceptance criteria
[ ] There is a generic solution to close the custom simulator - the exe and the command window (if opened to run the exe)
[ ] Once the test cases are run the solution kicks in and closes the exe/cmd window.
[ ] The solution should work in both the cases - All IOC tests are run and a specific IOCs test cases are run
How to Test
verbose instructions for reviewer to test changes
(Add before making a PR)
LowriJenkins
commented
4 months ago
Where?
As a developer we should be able to use a custom emulator (this is already possible) other than Lewis and after the tests have completed the emulator should close down graciously.
How?
Suppose you want to use a custom emulator for testing IOC. The solution is to use the following tags in the IOCs block: "emulator_launcher_class": CommandLineEmulatorLauncher, "emulator_command_line": "responder.bat", where responder.bat is a bat file that probably calls the simulator exe.
The issue is once the IOC tests are run and the simulator exe is executed, there probably there is no way to close the exe or the cmd window which ran the exe. The lindy ioc tests run into this issue, but have a rough solution that should be replaced.
Reproducible?
[Yes]
To Reproduce
-Remove kill the emulator from the end of the test bat and then run the lindy IOC test cases
Acceptance criteria
How to Test
verbose instructions for reviewer to test changes (Add before making a PR)
Time in Planning
28:48 02/05/24