ISISComputingGroup / IBEX

Top level repository for IBEX stories
4 stars 2 forks source link

DHP30330: Fix failing system tests #8305

Closed zsoltkebel closed 2 months ago

zsoltkebel commented 2 months ago

Problem

There seems to be an issue with the system tests for DHP30330:

tests.dhp30330.Dhp30330Tests.test_WHEN_no_stop_condition_THEN_stop_pv_is_not_processed_0__10_15_0_
tests.dhp30330.Dhp30330Tests.test_WHEN_no_stop_condition_THEN_stop_pv_is_not_processed_1__10_8_0_

The current and voltage value seems to be incosistent with the expected because the constant power mode stays on. The two PVs CONST:POW and CONST:POW:SP are not connected because the CONST:POW polls the device every 2 seconds. As there is no way to send const power mode setting to the device it seems that we can't connect the two PVs. So the CONST:POW:SP is not connected to the device in any way, it is used in the condition for whether or not to adjust voltage and current locally within the IOC.

Solution

The solution is to write 0 into the CONST:POW:SP in the reset function on top of resetting the device's internal state for const power.