ISISComputingGroup / IBEX

Top level repository for IBEX stories
4 stars 2 forks source link

eurotherm: handle missing sensor better #8310

Open FreddieAkeroyd opened 2 months ago

FreddieAkeroyd commented 2 months ago

As a developer i would like the eurotherm to handle a missing sensor better. As seen recently, the IOC was configured for sensors 1,2,3 but 1 had been removed. This resulted in calls to read sensor 1 timing out, but the queue of such reads caused other reads on 2 and 3 to time out, though occasionally a read from 2 or 3 would get through, so they were intermittently showing the right value but mostly in alarm.

maybe the read chain could be modified so that if the first read fails it does not continue the others in that chain on that iteration. It looks like may initiate reads viarecord(seq, "$(P)READ") ` every second. given timeouts in reads, i feel one approach may be to

Acceptance criteria

communication with a missing sensor does not affect other working sensors

Time in Planning

1:00:39 02/05/24

LowriJenkins commented 2 months ago

Freddie plans to make this ticket clearer, if you don't understand it, ask him.

isaachilly commented 1 month ago

Rework info

The Lewis test need to simulate just one addr being disconnected not all of them which it is currently doing. This may need writing a new Lewis command that only simulates the disconnection of one addr. Test needs to check it can write and read values from the other addr/s with 1/more addr being disconnected.