ISISComputingGroup / IBEX

Top level repository for IBEX stories
4 stars 2 forks source link

Instruments: handle local changes to calibration files #8315

Open FreddieAkeroyd opened 2 months ago

FreddieAkeroyd commented 2 months ago

Currently we have an instrument specific branch for configurations, but a separate repository for calibration files with all instruments on master. How do we handle local instrument changes e.g. locally created ramp files etc.

Acceptance Criteria

Time in Planning

00:49:49 02/05/24

FreddieAkeroyd commented 2 months ago

If we go for a local pushed instrument branch then we can track changes better and so potentially let other groups manage the area a bit themselves?

rerpha commented 2 months ago

the scientists already have a local calib directory which is their space really. perhaps we should make it more clear that if they want to use a custom file they need to use that directory?

FreddieAkeroyd commented 2 months ago

yes i think we need to make their local calib area clearer, then we need to discuss the scenario of a new temp sensor is needed in a hurry:

KathrynBaker commented 2 months ago

The main calib directory is kind of read only, the original idea was that the repo would be updated on instruments as part of a deploy, but new sensors could be added to the repo and pulled down as needed between times. The SSH script allows us to do these as a specific deploy. I think we were hoping to pass on the updating of the repo to SE at some point. Local variations or calibrations should be in the directory that Jack referred to above in that world.

isaachilly commented 1 week ago

Actions to take resulting from team meeting on 25/05/2024:

In order of first to do:

  1. Create Jenkins job to check the status of config dir. Similar to Scripts Divergence Check job we already have.
  2. Organise and have meeting with Maxim and relevant to discuss the process; either sticking to the previous agreement or modifying it.
  3. Based on the above meeting, if the reversion back to previous agreement causes the current system of local calib files to not be sufficient, deal with this as it occurs.