ISISComputingGroup / IBEX

Top level repository for IBEX stories
4 stars 2 forks source link

CHRONUS: Use Multiple CAENV895 Crates #8357

Closed LilithCole closed 1 month ago

LilithCole commented 1 month ago

As an instrument scientist, I want to be able to use multiple CARNV895 crates at once. The IOC and vendor library are theoretically able to load an arbitrary number of crates, but our startup needs to be altered to allow this. The vendor librry also requires certain id numbers to be passed to this, which should be configurable via macro

Acceptance Criteria

What is the acceptance criteria?

How to Test

verbose instructions for reviewer to test changes (Add before making a PR)

rerpha commented 1 month ago

How to review? can we test in any way or is this just code review?

LilithCole commented 1 month ago

just code review, additionally this is already patched onto CHRONUS as part of testing so you can see the OPI doing its thing if you point it at the IOC on there.

rerpha commented 1 month ago

cool, thanks. is it worth adding argus and chronus to https://github.com/ISISComputingGroup/IBEX/wiki#instrument-information--hotfixes and listing hotfixes, in case something doesn't get merged before we release to them again?

LilithCole commented 1 month ago

sure, I'll look at that