ISISComputingGroup / IBEX

Top level repository for IBEX stories
4 stars 2 forks source link

GUI: fix `uk.ac.stfc.isis.ibex.utilities` dependency definitions #8393

Open Tom-Willemsen opened 1 week ago

Tom-Willemsen commented 1 week ago

Where?

In the gui in uk.ac.stfc.isis.ibex.utilities we seem to have manual classpath entries pointing at the .m2 cache folder, looking for a byte-buddy version of 1.14.11. However the target platform is actually resolving 1.14.9 so this fails.

It would be better for it to use the standard OSGi dependency mechanisms to fix this problem at source, rather than pointing the classpath directly at the .m2 folder in an error-prone way.

While this doesn't prevent the GUI from launching in eclipse, we should not have "usual errors" which we ignore.

Marked as "good first issue" as the utilities application is very simple and you should be able to follow any OSGi hello-world style dependencies tutorial. There are also two examples in IBEX of applications defined in this way (main gui & script generator).

Acceptance criteria

How to Test

verbose instructions for reviewer to test changes (Add before making a PR)