iangillingham-stfc commented 3 weeks ago

Issue Description

As a developer, I am experiencing an error when trying to execute the IBEX-device-generator python script, which crashes during the "Add OPI to gui" stage.

How & Where?

How did the issue come about/known cause of issue if any?
Attempting to create new device support by running the IBEX-device-generator python script.
Where is the issue likely to be (be as specific as possible e.g. filepaths) After the prompt "Add OPI to gui?' it crashes with a traceback error, as the attached screenshot shows.

Reproducible (Yes/No)?

ibex_device_generator TLFW102C 6085 --device_name ThorlabsFW102C --device_count 3 --use_git --github_token -i

Additional Information

Acceptance Criteria

_{What is the acceptance criteria of this ticket? What should the reviewer expect to be complete?}

The IBEX-device-generator python script completes without error.

How to Review

_{Before making a PR...}

Provide verbose instructions for the reviewer to test that your changes work and fix the issue
Describe if/how you have implemented testing for this issue
Provide screenshots of the feature to help the reviewer if relevant

_{If not applicable, write "Not applicable"}

...

_{To the reviewer: Make sure to update submodules!}

GRyall commented 3 weeks ago

Can confirm I also encounter this. The workaround is to manually do the commit in the gui repo, as it is the last step in the script. The bug is I believe actually in the git pre-commit hook in the gui repo and how that then interacts with this script. I.e. I think the script makes sensible assumptions about how it expects the repo to behave and the repay defies those expectations....

rerpha commented 1 week ago

to complete this ticket we need to:

update https://github.com/ISISComputingGroup/IBEX-device-generator/blob/main/src/ibex_device_generator/templates/8/uk.ac.stfc.isis.ibex.opis/resources/%40%7Bopi_file_name%7D.opi to contain the dummy widget
add dummy widgets to the ones that are missing them and commit them

ISISComputingGroup / IBEX