search

ISISComputingGroup / lewis-ess

Let's write intricate simulators!
GNU General Public License v3.0
21 stars 19 forks source link

Only update PV and PV meta data on actual changes #256

Closed MichaelWedel closed 7 years ago

MichaelWedel commented 7 years ago

This fixes #254.

PV and PV meta-data are now updated and logged separately, and only when their values have actually changed. Also, another bug was fixed that made PVs with a meta_data_property read only.

To test, you could use the dual_device:

$ lewis -k lewis.examples -p epics -r localhost:10000 dual_device

Now use lewis-control to update a few values (upper_limit) and check in the log that the values are updated properly. Release notes will be added once #253 has been merged (the release notes file was created in that PR).

MichaelWedel commented 7 years ago

I've addressed the TODO comment by opening a PR with the changes against the pcaspy repository.

MichaelWedel commented 7 years ago

The upstream PR has been merged. Once a new pcaspy release is out, the _get_param_info method should be removed.

MikeHart85 commented 7 years ago

Looks good!